X Tutup
Skip to content

bpo-13497: Fix broken nice configure test#12041

Merged
benjaminp merged 1 commit intopython:masterfrom
ngie-eign:issue-13497
Feb 26, 2019
Merged

bpo-13497: Fix broken nice configure test#12041
benjaminp merged 1 commit intopython:masterfrom
ngie-eign:issue-13497

Conversation

@ngie-eign
Copy link
Copy Markdown
Contributor

@ngie-eign ngie-eign commented Feb 26, 2019 •
edited by bedevere-bot
Loading

Per POSIX, nice(3) requires unistd.h and exit(3) requires stdlib.h.

Fixing the test will prevent false positives with pedantic compilers,
like clang.

bpo-13497

Signed-off-by: Enji Cooper yaneurabeya@gmail.com

https://bugs.python.org/issue13497

@ngie-eign
Fix broken nice configure test
55edaa5 
Per POSIX, `nice(3)` requires `unistd.h` and `exit(3)` requires `stdlib.h`.

Fixing the test will prevent false positives with pedantic compilers,
like clang.

bpo-13497

Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
@benjaminp benjaminp merged commit 90c6fac into python:master Feb 26, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 26, 2019

Thanks @ngie-eign for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 26, 2019
@ngie-eign @miss-islington
closes bpo-13497: Fix broken nice configure test. (pythonGH-12041)
a58f45a 
Per POSIX, `nice(3)` requires `unistd.h` and `exit(3)` requires `stdlib.h`.

Fixing the test will prevent false positives with pedantic compilers like clang.
(cherry picked from commit 90c6fac)

Co-authored-by: ngie-eign <1574099+ngie-eign@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 26, 2019

GH-12042 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 26, 2019

GH-12043 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 26, 2019
@ngie-eign @miss-islington
closes bpo-13497: Fix broken nice configure test. (pythonGH-12041)
4426059 
Per POSIX, `nice(3)` requires `unistd.h` and `exit(3)` requires `stdlib.h`.

Fixing the test will prevent false positives with pedantic compilers like clang.
(cherry picked from commit 90c6fac)

Co-authored-by: ngie-eign <1574099+ngie-eign@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Feb 26, 2019
@miss-islington @ngie-eign
closes bpo-13497: Fix broken nice configure test. (GH-12041)
a0f656d 
Per POSIX, `nice(3)` requires `unistd.h` and `exit(3)` requires `stdlib.h`.

Fixing the test will prevent false positives with pedantic compilers like clang.
(cherry picked from commit 90c6fac)

Co-authored-by: ngie-eign <1574099+ngie-eign@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 26, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE Fedora 3.x has failed when building commit 90c6fac.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/85/builds/2209) and take a look at the build logs.
  4. Check if the failure is related to this commit (90c6fac) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/85/builds/2209

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_descr.py", line 4341, in test_vicious_descriptor_nonsense
    self.assertEqual(c.attr, 1)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_descr.py", line 4328, in __eq__
    del C.attr
AttributeError: attr

----------------------------------------------------------------------

Ran 140 tests in 2.609s

FAILED (errors=1, expected failures=2)


Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_descr.py", line 4341, in test_vicious_descriptor_nonsense
    self.assertEqual(c.attr, 1)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64le/build/Lib/test/test_descr.py", line 4328, in __eq__
    del C.attr
AttributeError: attr

----------------------------------------------------------------------

Ran 140 tests in 2.548s

FAILED (errors=1, expected failures=2)

miss-islington added a commit that referenced this pull request Feb 26, 2019
@miss-islington @ngie-eign
closes bpo-13497: Fix broken nice configure test. (GH-12041)
2055ebb 
Per POSIX, `nice(3)` requires `unistd.h` and `exit(3)` requires `stdlib.h`.

Fixing the test will prevent false positives with pedantic compilers like clang.
(cherry picked from commit 90c6fac)

Co-authored-by: ngie-eign <1574099+ngie-eign@users.noreply.github.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 26, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64 Fedora 3.x has failed when building commit 90c6fac.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/53/builds/2385) and take a look at the build logs.
  4. Check if the failure is related to this commit (90c6fac) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/53/builds/2385

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64/build/Lib/test/test_descr.py", line 4341, in test_vicious_descriptor_nonsense
    self.assertEqual(c.attr, 1)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64/build/Lib/test/test_descr.py", line 4328, in __eq__
    del C.attr
AttributeError: attr

----------------------------------------------------------------------

Ran 140 tests in 5.998s

FAILED (errors=1, expected failures=2)


Traceback (most recent call last):
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64/build/Lib/test/test_descr.py", line 4341, in test_vicious_descriptor_nonsense
    self.assertEqual(c.attr, 1)
  File "/home/shager/cpython-buildarea/3.x.edelsohn-fedora-ppc64/build/Lib/test/test_descr.py", line 4328, in __eq__
    del C.attr
AttributeError: attr

----------------------------------------------------------------------

Ran 140 tests in 3.856s

FAILED (errors=1, expected failures=2)

@ngie-eign ngie-eign deleted the issue-13497 branch February 26, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ngie-eign @miss-islington @bedevere-bot @benjaminp @the-knights-who-say-ni
X Tutup