X Tutup
Skip to content

[3.6] bpo-31374: Include pyconfig.h earlier in expat (GH-11064)#11072

Merged
miss-islington merged 1 commit intopython:3.6from
miss-islington:backport-cf24735-3.6
Dec 10, 2018
Merged

[3.6] bpo-31374: Include pyconfig.h earlier in expat (GH-11064)#11072
miss-islington merged 1 commit intopython:3.6from
miss-islington:backport-cf24735-3.6

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Dec 10, 2018

Include <pyconfig.h> ealier in Modules/expat/xmltok.c to define
properly _POSIX_C_SOURCE. Python defines _POSIX_C_SOURCE as 200809L,
whereas <features.h> (included indirectly by <string.h>) defines
_POSIX_C_SOURCE as 199506L.
(cherry picked from commit cf24735)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue31374

Include <pyconfig.h> ealier in Modules/expat/xmltok.c to define
properly _POSIX_C_SOURCE. Python defines _POSIX_C_SOURCE as 200809L,
whereas <features.h> (included indirectly by <string.h>) defines
_POSIX_C_SOURCE as 199506L.
(cherry picked from commit cf24735)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 7215e48 into python:3.6 Dec 10, 2018
@miss-islington miss-islington deleted the backport-cf24735-3.6 branch December 10, 2018 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup