X Tutup
Skip to content

[WIP] gh-107954: Add _PyConfig_Parse()#110145

Closed
vstinner wants to merge 1 commit intopython:mainfrom
vstinner:config_parse
Closed

[WIP] gh-107954: Add _PyConfig_Parse()#110145
vstinner wants to merge 1 commit intopython:mainfrom
vstinner:config_parse

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Sep 30, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 30, 2023
Closed
@vstinner
Copy link
Member Author

vstinner commented Sep 30, 2023

Discussion: https://discuss.python.org/t/fr-allow-private-runtime-config-to-enable-extending-without-breaking-the-pyconfig-abi/18004

@vstinner
Copy link
Member Author

vstinner commented Sep 30, 2023

It may be interesting to store unknown variables in a dictionary and expose it somewhere, similar to sys._xoptions. It would allow implement https://discuss.python.org/t/fr-allow-private-runtime-config-to-enable-extending-without-breaking-the-pyconfig-abi/18004 use case: private vendor-specific variables.

For that, the configuration format should have a deterministic way to get the type of unknown variable. In sys._xoptions, the key is a string and the value is a string or True if there is no value.

Looking at TOML specification, I see the following types would be interesting to support:

  • boolean
  • integer
  • string
  • array of string

@vstinner vstinner mentioned this pull request Oct 1, 2023
Merged
@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2023

I abandon this approach based on text configuration: see https://discuss.python.org/t/fr-allow-private-runtime-config-to-enable-extending-without-breaking-the-pyconfig-abi/18004/24 for the rationale.

Let's focus on PR #110176 PyInitConfig API instead which seem to be please more people.

@vstinner vstinner closed this Oct 2, 2023
@vstinner vstinner deleted the config_parse branch October 2, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 will be requested when the pull request is marked ready for review FFY00 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner
X Tutup