X Tutup
Skip to content

gh-104773: PEP 594: Remove the msilib package#104911

Merged
zware merged 2 commits intopython:mainfrom
zware:no_more_msilib
May 25, 2023
Merged

gh-104773: PEP 594: Remove the msilib package#104911
zware merged 2 commits intopython:mainfrom
zware:no_more_msilib

Conversation

@zware
Copy link
Copy Markdown
Member

@zware zware commented May 24, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
19 tasks
@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 25, 2023

msilib/__init__.py starts with from _msi import *: the _msi extension should be removed as well, no? Do you plan to remove it as a separated PR?

@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 25, 2023

Note: The msilib module was used by the bdist_msi command of distutils, but this command was removed in Python 3.11, and the whole distutils package was removed in Python 3.12. See the bdist_msi deprecation in Python 3.9 for the rationale: issue #83767.

Now it's fine to remove this deprecated msilib module. Well, PEP 594 has a longer rationale.

vstinner
vstinner approved these changes May 25, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The _msi extension can be removed in a separated PR.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 25, 2023

Using import msilib|from msilib regex, I found the following projects of PyPI top 5,000 projects (at 2023-04-13) using the removed msilib module.

Affected projects (2):

  • mpi4py (3.1.4)
  • pygame (2.3.0)
pygame-2.3.0/setup.py: import msilib
mpi4py-3.1.4/conf/mpidistutils.py: import msilib

@zware zware requested a review from a team as a code owner May 25, 2023 00:12
@zware zware requested a review from vstinner May 25, 2023 00:12
@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 25, 2023

Does Tools\msi\build.bat use msilib module or _msi extension? Or does it use Windows tooling instead?

There is .github/workflows/build_msi.yml which runs Tools\msi\build.bat, but I don't know what triggers this GHA job. Is it when one file in Tools/msi/ is modified?

It may be interesting to check that these tools and/or this GHA job still work ;-)

@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 25, 2023

Oh wait, I see a TestsMSI / Windows Installer (x64) (pull_request) In progress task running! It will tell us if it still works :-)

vstinner
vstinner approved these changes May 25, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The msilib LGTM. For the _msi removal, I'm not 100% confident that I can review the VS solution changes (but from what I saw, it LGTM as well).

@zware zware merged commit 98c4333 into python:main May 25, 2023
@zware zware deleted the no_more_msilib branch May 25, 2023 01:06
@hugovk hugovk changed the title gh-104773: Remove the msilib package gh-104773: PEP 594: Remove the msilib package May 25, 2023
@Ahajha Ahajha mentioned this pull request Feb 9, 2024
Merged
3 tasks
@Ahajha Ahajha mentioned this pull request Nov 29, 2024
Closed
dutow added a commit to dutow/conan-center-index that referenced this pull request Mar 30, 2026
@dutow
cpython: add patches for 3.13.12 and 3.14.3
6733dcb 
Version-specific patches adapted from existing ones:

- relocatable-python-config: same change as 3.x-0001 but adjusted
  for line offset in 3.13+ python-config.sh.in (shared between
  3.13 and 3.14 since the file is identical)

- remove-module-deps: removes ProjectDependencies from the python
  project in PCbuild/pcbuild.sln (separate patches for 3.13 and
  3.14 due to different GUID sets)

- _ctypes-ffi (3.13 only): converts static formattable[] array to
  dynamic initialization for shared libffi compatibility. Not needed
  for 3.14 where this was fixed upstream by restructuring cfield.c
  into a named struct (python/cpython#117671)

The _msi-vcxproj patch is no longer needed since msilib was removed
in 3.13 per PEP 594 (python/cpython#104911).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zware @vstinner @bedevere-bot
X Tutup