Note which fields can be used with environment markers#416
Merged
theacodes merged 1 commit intopypa:masterfrom Dec 12, 2017
Merged
Note which fields can be used with environment markers#416theacodes merged 1 commit intopypa:masterfrom
theacodes merged 1 commit intopypa:masterfrom
Conversation
From PEP 345 Closes pypagh-409
theacodes
approved these changes
Dec 12, 2017
Member
|
Thanks @takluyver. Re:
Perhaps @ncoghlan or @dstufft has some insight here. I'm going to go ahead and merge- we can address post-hoc comments in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 345 lists six fields which can have environment markers. I've noted it for all six, but I don't know if I should. In particular, I've never seen a classifier listed with an environment marker, and it doesn't make much sense to me to allow that.
I've also updated the specification of
Requires-Distwith a brief summary of PEP 508.Closes gh-409