Merged
Conversation
di
force-pushed
the
metadata-1.3-updates
branch
from
87982ad to
8fe8677
Compare
takluyver
reviewed
Dec 8, 2017
| regex (run with ``re.IGNORECASE``):: | ||
|
|
||
| The name of the distributions. | ||
| ^([A-Z0-9]|[A-Z0-9][A-Z0-9._-]*[A-Z0-9])$ |
Member
There was a problem hiding this comment.
Is it worth adding a prose description of this as well? Here's some words we could use:
A valid name consists only of ASCII letters and numbers, period, underscore and hyphen. It must start and end with a letter or number.
Member
|
PEP 566 has been accepted: python/peps@c839748 However, the PR requires a few updates to match the accepted version of the PEP:
|
Member
Author
|
@ncoghlan I think I've addressed all your points (thank you for the checklist, BTW). Could you review/merge? |
ncoghlan
approved these changes
Mar 4, 2018
Member
|
Huzzah! I'll go mark the PEP as Final as well :) |
ncoghlan
added a commit
to python/peps
that referenced
this pull request
Mar 4, 2018
pypa/packaging.python.org#412 has been merged, updating the core metadata specification to match the PEP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR captures all changes we need to make now that PEP 566 is accepted.
Fixes #410, fixes #411, closes #449.
(cc @takluyver)