Update single-sourcing-package-version.rst#400
Merged
ncoghlan merged 2 commits intopypa:masterfrom Nov 21, 2017
Merged
Conversation
Contributor
VDuda
commented
Nov 20, 2017
VDuda
commented
- Bump example link to master from antiquated 1.5.6 tag (we should at least bump it to the latest tag)
- Fix for read function to match with current state of pip example
* Bump example link to master from antiquated 1.5.6 tag (we should at least bump it to the latest tag) * Fix for read function to match with current state of pip example
pradyunsg
approved these changes
Nov 20, 2017
pradyunsg
reviewed
Nov 20, 2017
| encoding=kwargs.get("encoding", "utf8") | ||
| ) as fp: | ||
| def read(*parts): | ||
| with codecs.open(os.path.join(here, *parts), 'r') as fp: |
Member
There was a problem hiding this comment.
You'll want to include the line defining here. :)
Include/define `here` variable
Member
|
Thanks @VDuda! This looks good to me as is. I am not sure if we want the guide to recommend using I'll wait for someone else. (it's not like I can merge this anyway) |
ncoghlan
approved these changes
Nov 21, 2017
Member
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
We don't show any of the other imports (i.e. os.path), so I'm OK with leaving out the explicit codecs import in the example.
Member
|
Thanks @VDuda! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.