X Tutup
Skip to content

Add a license section to the distributing guide#331

Merged
theacodes merged 2 commits intopypa:masterfrom
theacodes:add-license-to-guide
Jun 23, 2017
Merged

Add a license section to the distributing guide#331
theacodes merged 2 commits intopypa:masterfrom
theacodes:add-license-to-guide

Conversation

@theacodes
Copy link
Member

Resolves #275

@theacodes theacodes requested review from ddbeck and ncoghlan June 23, 2017 16:25
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding this, Jon.

If you're unsure which license to choose, you can use resources such as
`GitHub's Choose a License <https://choosealicense.com/>`_ or consult a lawyer.

For an example, see the `LICENSE.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less a change suggestion and more of an observation: I would write "see file_name from…" or "see the file_name file from…" This is a personal preference I had no idea I even had until this moment, so thank you for this learning experience. 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to be consistent here. We'll eventually replace this whole page with new tutorials, so I'm just trying to get a band-aid in place for the time being. :)

@theacodes theacodes merged commit c49bd8e into pypa:master Jun 23, 2017
@theacodes theacodes deleted the add-license-to-guide branch June 23, 2017 16:47
ncoghlan pushed a commit to ncoghlan/packaging.python.org that referenced this pull request Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup