Suggest import for name causing a UnknownName error#3716
Open
csicar wants to merge 5 commits intopurescript:masterfrom
Open
Suggest import for name causing a UnknownName error#3716csicar wants to merge 5 commits intopurescript:masterfrom
csicar wants to merge 5 commits intopurescript:masterfrom
Conversation
Author
|
|
Previously errorSuggestion returned `(Just "")` for UnusedImport and DuplicateImport and `Nothing` for any other ErrorMessage that has no suggestions. Both `Just ""` and `Nothing` seem to be treated the same and represented as `""` in the rendered versions. The matching imports suggestions for UnknownName now are represented as seperate suggestions, which allow for proper rendering. The JSON represenation of multiple suggestions is still a single string, as changing that would require changing the JSON schema.
to reflect the changed return type. Imports and shadowing were also cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the adds a Hint to the UnknownName error, if a module exports the same name. It (should) support all names including types, type classes, values etc.
Changes
Make.makeToDos
Prelude (map)is already imported, suggestPrelude (map, class Show)If there is interest in this, I'll implement these ToDos.
Ensuring, that the value has the correct type would be nice but seems quite involved, as none of the data structures available at the necessary places seem to have type information available.
Example: