Merged
Conversation
commit: |
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
seiyab
commented
Mar 9, 2026
Comment on lines
82
to
85
| export const Test = () => { | ||
| return <p>test</p>; | ||
| }; | ||
|
|
||
| return <p>test</p>; | ||
| }; | ||
| <Test /> |
Collaborator
Author
There was a problem hiding this comment.
Input:
{/* prettier-ignore-start */}
export const Test = () => {
return <p>test</p>;
};
<Test />
{/* prettier-ignore-end */}
seiyab
commented
Mar 9, 2026
Comment on lines
705
to
708
| <ul> | ||
| <li>item </li> | ||
| <li>item {" "} </li> | ||
| <li /> | ||
| </ul> |
Collaborator
Author
There was a problem hiding this comment.
Input:
<ul>
<li >item {' '} </li>
<li/>
</ul >As another approach, we can probably render mdxFlowElement as embedded JSX expression. It will output <li>item </li> as main, I guess.
Member
There was a problem hiding this comment.
I think you are right about this.
seiyab
commented
Mar 9, 2026
Comment on lines
+183
to
+188
| if (options.parser === "mdx") { | ||
| const paragraph = path.findAncestor((node) => node.type === "paragraph"); | ||
| if (paragraph?.hasMdxJsx) { | ||
| return true; | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Without this:
- <ExternalLink href="http://example.com">Prettier</ExternalLink> is an
- opinionated-code-formatter-that-support-many-languages-and-integrate-with-most-editors
+ <ExternalLink href="http://example.com">Prettier</ExternalLink> is an opinionated-code-formatter-that-support-many-languages-and-integrate-with-most-editorsNote that the failed on on branch mdx might somewhat make sense because the option proseWrap is preserve in the test. With proseWrap: 'always', mdx branch breaks the paragraph.
IMO, it should break such paragraph because:
- It's more compatible to current Prettier
- JSX looks more appropriate as its context than prose
fisker
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FULL_TEST=1 yarn test tests/format/mdxpasses on this branch.Failing tests
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.