X Tutup
Skip to content

Add test instructions#217

Closed
nagromc wants to merge 6 commits intopre-commit:masterfrom
nagromc:test-instructions
Closed

Add test instructions#217
nagromc wants to merge 6 commits intopre-commit:masterfrom
nagromc:test-instructions

Conversation

@nagromc
Copy link
Contributor

@nagromc nagromc commented Jul 17, 2017

No description provided.

@nagromc
Copy link
Contributor Author

nagromc commented Jul 17, 2017

Just realized there is https://github.com/pre-commit/pre-commit/blob/master/CONTRIBUTING.md

FML

Maybe some parts can be merged? Especially the parts where the existing Git configuration interfere with the test runner. I've been quite annoyed by this problem.

@asottile
Copy link
Member

While I think this is all correct and useful information, a lot of it is duplicated with the general tox documentation and CONTRIBUTING in pre-commit/pre-commit.

Note also that if you find your git configuration conflicting with the tests, we consider it a bug, that should be fixed and would welcome changes to improve the testsuite or hooks themselves to be more resistant to alternate git configurations :)

I'm also not sure enumerating the supported python versions is necessary or useful as that information is already in setup.py and tox.ini (two standard places to search for this information).

@asottile
Copy link
Member

asottile commented Sep 4, 2017

We'll handle this in pre-commit/pre-commit#564

@asottile asottile closed this Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup