Increase robustness of tests involving git#121
Merged
asottile merged 1 commit intopre-commit:masterfrom Jun 12, 2016
sanmai-NL:Tox_fix_autosigning_upon_git_commit
Merged
Increase robustness of tests involving git#121asottile merged 1 commit intopre-commit:masterfrom sanmai-NL:Tox_fix_autosigning_upon_git_commit
git#121asottile merged 1 commit intopre-commit:masterfrom
sanmai-NL:Tox_fix_autosigning_upon_git_commit
Conversation
1. Disable automatic `git commit` GPG-signing, since that requires interaction. This issue was encountered in practice by me, causing spurious test failures 2. In case path operands could turn out to start with dashes, escape the operand list with '--'.
Member
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git commitGPG-signing, since that requires interaction. This issue was encountered in practice by me, causing spurious test failures.--.