X Tutup
Skip to content

Add/remove mesh instance#7844

Open
LeXXik wants to merge 2 commits intoplaycanvas:mainfrom
LeXXik:lxk-mesh-instance
Open

Add/remove mesh instance#7844
LeXXik wants to merge 2 commits intoplaycanvas:mainfrom
LeXXik:lxk-mesh-instance

Conversation

@LeXXik
Copy link
Contributor

@LeXXik LeXXik commented Jul 21, 2025 •
edited
Loading

Fixes #6680

Adds new API:

const mesh = Mesh.fromGeometry(app.graphicsDevice, new BoxGeometry());
const instance = new MeshInstance(mesh, new StandardMaterial());

entity.render.addMeshInstance(instance);
entity.render.removeMeshInstance(instance);

Tests included.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@LeXXik LeXXik marked this pull request as ready for review July 21, 2025 11:32
@Maksims
Copy link
Collaborator

Maksims commented Jul 21, 2025

This is very useful! We had cases where we needed to do that, we had to slice the meshInstances array, then modify it and assign again, but that leads to unnecessary re-initializations and layers stuff, is just not efficient to do at runtime as it could be.
In this PR there is no unnecessary work, which is great.

@Maksims
Copy link
Collaborator

Maksims commented Sep 3, 2025

We need this!

@Maksims Maksims requested a review from mvaligursky September 3, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mvaligursky mvaligursky Awaiting requested review from mvaligursky

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RenderComponent - ability to dynamically add/remove MeshInstance.

2 participants

@LeXXik @Maksims
X Tutup