Improve calculations in AIMatchVel (AIChangeVelBy)#6296
Open
Gliese852 wants to merge 6 commits intopioneerspacesim:masterfrom
Open
Improve calculations in AIMatchVel (AIChangeVelBy)#6296Gliese852 wants to merge 6 commits intopioneerspacesim:masterfrom
Gliese852 wants to merge 6 commits intopioneerspacesim:masterfrom
Conversation
Gliese852
force-pushed
the
better-aimatchvel
branch
2 times, most recently
from
de0ef65 to
e152fdf
Compare
Vital update is SDL2 with 'offscreen' video driver support. Also replaced apt-fast which is now missing from the image and the default repository, with apt-get.
The problem with the current version is that if the powerful thruster is turned away from the direction of the required speed, it pushes the ship to the side when gaining speed. This happens because the velocity vector is decomposed along the directions of the thrusters, and each thruster independently tries to maximize its component. In the new version it is done so that the direction of the thrust vector necessarily coincides with the direction of the required speed.
for testing purposes
Otherwise, the linker discards the symbol "OutputVersioningInfo", and then a linking error occurs.
Gliese852
force-pushed
the
better-aimatchvel
branch
from
c450c67 to
1fed631
Compare
Contributor
Author
|
Hurray, CI is working! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem with the current version is that if the powerful thruster is turned away from the direction of the required speed, it pushes the ship to the side when gaining speed. This happens because the velocity vector is decomposed along the directions of the thrusters, and each thruster independently tries to maximize its component.
In the new version it is done so that the direction of the thrust vector necessarily coincides with the direction of the required speed.
Also wrote tests that allow to see the problem with the previous implementation and test the new one.