fmt::arg("unit", counter.unit) causes crash, hard code counter.unit#6256
Merged
fluffyfreak merged 1 commit intopioneerspacesim:masterfrom Nov 29, 2025
Merged
Conversation
Contributor
Author
|
Merged this for now, it can be fixed / tweaked easily enough as it's just one line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately the upgrade to libfmt v12.1.0 seems to break the PerfInfo screen.
Specifically the use of fmt::arg("unit", counter.unit) causes it to crash now.
To see this happen just open the Debug Tools with
ctrl+iand then click the second tab for performance info.This is something of a rubbish fix, but haven't been able to work out a better one.
Suggestions for how to really fix the problem are welcome.