Cargo Run custom risk message#6192
Conversation
impaktor
left a comment
impaktor
left a comment
There was a problem hiding this comment.
Left some string suggestions.
Also, there's plenty of debug prints, but this PR is still set as WIP, so only natural I suppose.
@zonkmachine What additional work remains for it to be ready for merge/review?
data/lang/module-cargorun/en.json
Outdated
| }, | ||
| "EXPLOSIVES_RISK_MESSAGE_1": { | ||
| "description": "Answer to question: Will I be in any danger?", | ||
| "message": "Well, it's explosives." |
There was a problem hiding this comment.
I wonder if you could have a second sentence following it, "Not unless you drop it", since player might think there's some random chance their cargo hold will explode (though seasoned players will know that mechanics is not implemented).
With "not unless you drop it" I think the player knows there's no "drop" mechanism, so no actual danger.
There was a problem hiding this comment.
Looking into.
seasoned players will know that mechanics is not implemented).
It isn't?
Captain, there's a strange noise coming from the cargo hold! 😉
zonkmachine
force-pushed
the
riskmessage
branch
from
9d43755 to
4b0810e
Compare
|
Rebased with suggested changes. I'll look into the rest of the code soon-ish. |
zonkmachine
force-pushed
the
riskmessage
branch
3 times, most recently
from
c3eb1c2 to
dac620e
Compare
I looked it over and removed debug stuff and old commented out code. It works fine. I don't remember why I handle the risk messages in CommodityType.lua. Maybe it should be redone in Cargo Run altogether? The codedoc part for GetRiskMessage() has been tested and looks fine. -- Method: GetRiskMessage()
--
-- Returns alternative string for possible danger of the mission. Not all
-- cargo has the same danger involved.
function CommodityType:GetRiskMessage() |
|
Yes, please move mission-specific code out of core libs... If it's something that will be displayed homogeneously across the UI (e.g. a stolen or volatile cargo flag) that's a worthy inclusion, but a humorous message is IMO not worth promoting to "shared" API. |
|
OK. Converting to draft and redoing. |
zonkmachine
force-pushed
the
riskmessage
branch
from
dac620e to
155d080
Compare
Fixed! |
zonkmachine
force-pushed
the
riskmessage
branch
from
155d080 to
dee55cd
Compare
sturnclaw
left a comment
sturnclaw
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for working on this!
|
Thanks for the feedback everyone! I think I'm done here. I'll wait a bit with merging until things are being pulled back from Transifex, and maybe someone spots something that needs fixing. I tried to come up with other cargo that deserved an alternative risk message but don't have it in me at the moment. |
|
|
Add some variation to risk message when the risk is low. Co-authored-by: Axtel Sturnclaw <sturnclaw@protonmail.com> Co-authored-by: Karl F <karlfogel@gmail.com>
zonkmachine
force-pushed
the
riskmessage
branch
from
01cc317 to
25bdf5a
Compare
|
OK, merging. |
3 participants
Alternative strings for the 'Will I be in any danger' message.
Spice up the risk messages with occasional per cargo messages. You can have more than one alternative string and it's only considered when there is no risk involved.
Mission
Default risk message
Alternative per cargo risk message
