Prevent invoking SDL_PauseAudioDevice when it's already paused#6156
Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom Jun 12, 2025
Merged
Prevent invoking SDL_PauseAudioDevice when it's already paused#6156sturnclaw merged 1 commit intopioneerspacesim:masterfrom
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Conversation
sturnclaw
approved these changes
Jun 12, 2025
Member
sturnclaw
left a comment
sturnclaw
left a comment
There was a problem hiding this comment.
Thanks! We've had a few scattered reports of performance issues on the sound page, but never anything I could actually reproduce to figure out the problem. I appreciate you taking the time to dig into this one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #6155
The way the Sound menu is implemented is that it will continuously hammer the
Sound::Pausefunction, which apparently causes audio artifacts on my system. Why the Flatpak is not affected is not clear to me, one possibility is that the underlying SDL version is different.This patch makes sure that the
SDL_PauseAudioDeviceis only called when it would actually modify the pause state.