Add System and Trade Route Bookmark Interface#6154
Merged
sturnclaw merged 11 commits intopioneerspacesim:masterfrom Jun 12, 2025
Merged
Add System and Trade Route Bookmark Interface#6154sturnclaw merged 11 commits intopioneerspacesim:masterfrom
sturnclaw merged 11 commits intopioneerspacesim:masterfrom
Conversation
…ffset - GlyphButton is used to draw icons. It should not attempt to align with other text, as it does not render text.
- ui.textEllipsis() clips text and renders an ellipsis when the text runs out of the available content region. - ui.alignToLineHeight() now takes a proportion parameter, which controls the vertical position of the aligned text. - ui.sameLine can take a negative pos_x parameter, which is interpreted as an offset from the right-side content region edge. The spacing) parameter is also interpreted as an offset from the right edge in this mode.
- These styles are meant to encapsulate common push/pop operations used to achieve a consistent look and feel across the UI. - Technically these could be part of the theme, however they operate on the level of semantic color names and as such are theme-invariant.
- Supports setting size and centered position via parameters on the window object. - Can apply an optional style when rendering. - Prevent errors during the modal render function from cascading up the stack.
- Allows UI.Module objects to be used transparently as sidebar modules by calling their update() function before rendering. - Handle an exclusive module being default-active (e.g. after a hot-reload. - Update type information for UI.Sidebar.Module to include default-active state.
- Bookmarked systems are displayed in a new sidebar tab on the sector map. - Custom notes can be associated with bookmarks. - Systems as well as individual bodies in those systems can be bookmarked. - Support for displaying trade-route bookmarks is also provided, though the system-econ-view has not yet been updated.
- With the deprecation of the color argument to Imgui::Image, our old icon rendering was affected.
- Available with trade computer installed, for all commodities that aren't illegal in both the source and destination systems. - That's it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surprisingly, we don't have a feature request for this one.
This PR extends the work done recently on the SectorMap interface to add a new Bookmarks tab, allowing the player to bookmark interesting systems, add custom notes to their bookmarks, and bookmark trade routes between systems (with a Trade Computer installed).
(Pardon the missing cursor in these screenshots...)
This PR has been somewhat extensively tested to ensure it works correctly during hyperspace, etc. but more testing is as always appreciated. I intend to merge this sometime in the next few days unless I receive significant review feedback.