Fix pressure limit value if no atmo shield is installed#6117
Fix pressure limit value if no atmo shield is installed#6117sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Conversation
| false, | ||
| { l.ATMOSPHERIC_SHIELDING..":", atmo_shield and l.YES or l.NO }, | ||
| { l.ATMO_PRESS_LIMIT..":", string.format("%d atm", shipDef.atmosphericPressureLimit * atmo_shield_cap) }, | ||
| { l.ATMO_PRESS_LIMIT..":", string.format("%d atm", atmo_shield_cap == 0 and shipDef.atmosphericPressureLimit or shipDef.atmosphericPressureLimit * atmo_shield_cap) }, |
There was a problem hiding this comment.
This can be removed if you change the first line to math.max(player["atmo_shield_cap"], 1).
|
I've tested the PR quite thoroughly and it works. The whole atmospheric shield is a bit unclear to me though. All ships in the ship market are flagged as"Atmospheric capable: Yes" and upon purchase, in the "Ship information" they all say "Atmospheric shielding: No". Are these two not describing the same thing? Are all ships supposed to be capable on landing on planets? Including DSMiner? |
|
@zonkmachine Not all planets have atmospheres. Or to put it better: They're all capable of having the shielding, but not all of them do. You could sell it because you don't intend to use it for example. |
If I back some 500 commits on master (f0478a5), and start the game just to check out the ship markets, the ship models Nerodia and DSMiner only shows up on the space station on the Barnard's star start. They are the only ones that has the element atmo_shield explicitly defined and they are both set to 0. Also, on this commit, both the ship market and the ship information page has the same term "Atmospheric shielding" and it seem to mean the same thing. If all ships are potentially ""Atmospheric capable", and always answered 'yes', then that's not very interesting info on a ship prospect. |
053d212 to
551f378
Compare
|
Atmospheric shielding and atmospheric pressure tolerance does need some work, but it's a better topic for after the hotfix is released I think. There may have been a regression where the DSMiner, etc. now have the ability to receive atmospheric shielding where they did not before, and that's a topic we can tackle during the current development cycle after this hotfix is released. |
The ship info screen shows always 0 atm if no atmospheric shield is installed.