Merged
Conversation
Contributor
|
That Pumpkinseed, the bevels really in the details 😈 |
Member
|
@bszlrd Nice! The Coronatrix has some weaker fixed red/green lights in the middle section that are still wrong. |
Contributor
Author
Member
Yes. The light is coming from coronatrix_glow.dds. Edit: I think... |
Member
|
@bszlrd will you be fixing the Coronatrix (et. al) texture before merge? |
Contributor
Author
|
What's the ETA for release? |
Member
|
Soon-ish. Need to merge this and figure out where the PR that changed the ship JSON values went, and I'll do a pass through the other PRs as I have available time and mental capacity. |
Contributor
Author
|
Okay, I don't think I'll be able to do anything about the texture then for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Swapped the red-green navlights on the Coronatrix, Nerodia and Storeria.
Fixes #5591
Re-fixed the stray foating triangle that was caused by some non-manifold hidden geometry:

Fixes: #6094
Fixed mushed normals I likely introduced with the tag update for the Malabar and Vatakara:


Cleaned up the Pumpkinseed, which had a lot of unneded sharp edges, which turned out to be some odd bevel-like things, likely introduced from some import-reexport precision issue I think.


I've also added bevels while I was at it: