Combat mission - Strings#6102
Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom Apr 25, 2025
Merged
Conversation
17e4368 to
56bf2b1
Compare
Member
Author
* a/an * Upper/lower case * Rename variable 'type' as this is a Lua built-in function
56bf2b1 to
bc854c2
Compare
impaktor
reviewed
Apr 2, 2025
| }, | ||
| "MISSION_TYPE_CONVO_2": { | ||
| "description": "Name of mission type, used in conversation", | ||
| "message": "an armed reconnaissance" |
Member
There was a problem hiding this comment.
I wonder if this makes it hard to translate, when it's a fraction of a sentence. Perhaps description could mention which other translation variable makes use of it, and/or provide example sentence with surrounding context?
Member
Author
There was a problem hiding this comment.
Eventually it gets hard to translate but this is really just the same as the fix for the ships. I think we're good. This time...
Member
search and rescue might have similar sentence construction? |
sturnclaw
approved these changes
Apr 25, 2025
Member
sturnclaw
left a comment
There was a problem hiding this comment.
Eventually we may want a more powerful translation system but for now this is a good solution - thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixed wonky strings in the Combat mission.
Before

After
