X Tutup
Skip to content

Combat mission - Strings#6102

Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
zonkmachine:combatmissionstrings
Apr 25, 2025
Merged

Combat mission - Strings#6102
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
zonkmachine:combatmissionstrings

Conversation

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Mar 30, 2025

Fixed wonky strings in the Combat mission.

  • Wrong case
  • a/an
  • Change name of variable 'type', which is a Lua built-in function.

Before
combat

After
combat3

@zonkmachine zonkmachine force-pushed the combatmissionstrings branch from 17e4368 to 56bf2b1 Compare March 30, 2025 20:47
@zonkmachine
Copy link
Member Author

zonkmachine commented Mar 30, 2025

It's a bug fix but if you restart an old project with it there may be some minor issues. The one I've found is the article being used twice. As in the first example above. "a an armed reconnaissance"

combat2

* a/an
* Upper/lower case
* Rename variable 'type' as this is a Lua built-in function
@zonkmachine zonkmachine force-pushed the combatmissionstrings branch from 56bf2b1 to bc854c2 Compare March 30, 2025 21:28
},
"MISSION_TYPE_CONVO_2": {
"description": "Name of mission type, used in conversation",
"message": "an armed reconnaissance"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this makes it hard to translate, when it's a fraction of a sentence. Perhaps description could mention which other translation variable makes use of it, and/or provide example sentence with surrounding context?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually it gets hard to translate but this is really just the same as the fix for the ships. I think we're good. This time...

@impaktor
Copy link
Member

impaktor commented Apr 2, 2025

git grep -i " a {" data/lang/*en.json 

search and rescue might have similar sentence construction?

Copy link
Member

@sturnclaw sturnclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually we may want a more powerful translation system but for now this is a good solution - thanks!

@sturnclaw sturnclaw merged commit 2fa022f into pioneerspacesim:master Apr 25, 2025
@zonkmachine zonkmachine deleted the combatmissionstrings branch April 25, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup