Balancing the Scout mission ads#6095
Conversation
I love your way of doing it. This is just me getting stressed up when it's time for release and I see a random bug. It looked easy and safe enough to make it into the next release. It's quite an annoying bug. As for the method, I think your way of doing it is super nice and I think this should be revisited for a proper makeover. |
|
Marked as a draft as I found some issues. Will look into this in the evening. |
I misread the code for ad removal in onUpdateBB and have reverted that part of the PR but instead made some changes for improved clarity. I also softened the change in adverts created just slightly. This is now just a one-liner which cuts the number of adverts created by the Scout module from about 2 per day to 1 every 3rd day. |
zonkmachine
force-pushed
the
scoutads
branch
3 times, most recently
from
f266117 to
926ee94
Compare
|
Did a last push to make the code more clear. Squashed and done. |
|
Can I merge this? The only change I would do personally is do an even more drastic cut in Scout missions but I think maybe it's best to gradually dial in the right level. There is also the prospect of having a more advanced algorithm that takes population and other system data into consideration. |
Fine by me |
The Scout module creates on average two new ads every day. If the player sits on or around the same station for a month or more this will eventually build up to over a hundred ads. This PR slows down the creation of new ads by one sixth to about one new ad every three days. In response to pioneerspacesim#5760
2 participants
In response to #5760 where the BBS over time lose balance as some modules take over. Especially the Scout module keeps adding missions in excess of the demand. This is a quick fix to soften the issue and with this PR the missions balance out at around ~30 missions per station if none is take by the player.
The fix works by creating fewer adverts for Scout missions. One sixth of previous rate.
I haven't tested this other than sitting at Cydonia for 9 months and watching the mission list build up.
Here is what it looks like on master when the missions build up while not doing anything.