Change modelcompiler single model filepathing, change Editor location for MSVC#6063
Merged
fluffyfreak merged 2 commits intopioneerspacesim:masterfrom Feb 13, 2025
Merged
Conversation
sturnclaw
reviewed
Feb 14, 2025
| } | ||
| // find all of the models | ||
| FileSystem::FileSource &fileSource = FileSystem::gameDataFiles; | ||
| for (FileSystem::FileEnumerator files(fileSource, "models", FileSystem::FileEnumerator::Recurse); !files.Finished(); files.Next()) { |
Member
There was a problem hiding this comment.
Post-facto review: there is a significantly nicer range-for iterator available for FileEnumerator now, if you happen to revisit this code.
// Full typename included for informational purposes, feel free to abbreviate to auto
for (const FileSystem::FileInfo &info : fileSource.Enumerate("models", FileSystem::FileEnumerator::Recurse)) {
// ...
}
// Alternatively:
for (const FileSystem::FileInfo &info : fileSource.Recurse("models" /*, additional flags */)) // ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a bug/issue when trying to convert a single model to SGM format. It would only output the SGM to the full filepath if I specified
inplaceor some other 3rd parameter.I've changed this to always find the full filepath regardless of having extra parameters.
The
Editor.exewas also being output to a folder which meant I couldn't debug it from MSVC so for MSVC builds it now output to the CMAKE_SOURCE_DIR like the game and other tools.