X Tutup
Skip to content

Replace texture2D() with texture()#6045

Merged
fluffyfreak merged 1 commit intopioneerspacesim:masterfrom
fluffyfreak:fix-ring-shader-texture2d
Feb 4, 2025
Merged

Replace texture2D() with texture()#6045
fluffyfreak merged 1 commit intopioneerspacesim:masterfrom
fluffyfreak:fix-ring-shader-texture2d

Conversation

@fluffyfreak
Copy link
Contributor

Urgh, texture2D is deprecated, it's replacement texture is the one to use.

Bug made possible by nVidia drivers just working despite that 🤦 always catches me out.

image
A big thankyou to Natrix BQ-3566 pilot from the Discord channel for pointing it out.

@fluffyfreak fluffyfreak added Bug fix Rendering Everything related to rendering labels Feb 4, 2025
@fluffyfreak fluffyfreak requested a review from sturnclaw February 4, 2025 14:20
@fluffyfreak
Copy link
Contributor Author

@impaktor I'll merge this since it's tested and a well known type of change, we've already made it elsewhere in the code

@fluffyfreak fluffyfreak merged commit 3b71959 into pioneerspacesim:master Feb 4, 2025
@fluffyfreak fluffyfreak deleted the fix-ring-shader-texture2d branch February 4, 2025 22:09
@sturnclaw
Copy link
Member

Whoops, that's also my bad. Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug fix Rendering Everything related to rendering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup