Removing normal map from default cockpit materials#5964
Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom Nov 12, 2024
Merged
Removing normal map from default cockpit materials#5964sturnclaw merged 1 commit intopioneerspacesim:masterfrom
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Conversation
Contributor
|
"The best part is no part" |
Contributor
|
Before making a decision would you mind adding a with/without comparison? |
Contributor
Author
Member
|
If the normal map was never committed to the repo, then I'd say go ahead and just remove it from the materials entirely. We can revisit it when we implement "proper" lighting, though if we move to tiling materials rather than baked maps to complement our this-decade lighting approach, we probably won't need the normal map anyways. |
Contributor
Author
|
It wasn't. The commit removes the references to it |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes #5960
I do have the normal map, I forgot to include it, it seems. But its effect is negligible, and the file is 6mb, so I'd rather remove it. (Or I could add it if you peeps think it should be there, could also reduce its 4k size).