X Tutup
Skip to content

Removing normal map from default cockpit materials#5964

Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
bszlrd:default_cockpit_norm
Nov 12, 2024
Merged

Removing normal map from default cockpit materials#5964
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
bszlrd:default_cockpit_norm

Conversation

@bszlrd
Copy link
Contributor

@bszlrd bszlrd commented Nov 12, 2024

Fixes #5960
I do have the normal map, I forgot to include it, it seems. But its effect is negligible, and the file is 6mb, so I'd rather remove it. (Or I could add it if you peeps think it should be there, could also reduce its 4k size).

@mwerle
Copy link
Contributor

mwerle commented Nov 12, 2024

"The best part is no part"

@fluffyfreak
Copy link
Contributor

Before making a decision would you mind adding a with/without comparison?
Also as it's a normal map perhaps we can get away with a lower 1kx1k, or even 2kx2k resolution?

@bszlrd
Copy link
Contributor Author

bszlrd commented Nov 12, 2024

With:
screenshot-20241112-151724
Without:
screenshot-20241112-152048

Here's the normal map, if you want to try it out:
default_cockpit_norm

And here it is with cranked up contrast. Mosty the details are on the seat:
kép

@sturnclaw
Copy link
Member

If the normal map was never committed to the repo, then I'd say go ahead and just remove it from the materials entirely. We can revisit it when we implement "proper" lighting, though if we move to tiling materials rather than baked maps to complement our this-decade lighting approach, we probably won't need the normal map anyways.

@bszlrd
Copy link
Contributor Author

bszlrd commented Nov 12, 2024

It wasn't. The commit removes the references to it

@sturnclaw sturnclaw merged commit cf89d71 into pioneerspacesim:master Nov 12, 2024
@sturnclaw
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default_cockpit_norm.png missing from models/cockpits/default_cockpit/

4 participants

X Tutup