Misc. improvements#5937
Merged
sturnclaw merged 12 commits intopioneerspacesim:masterfrom Oct 13, 2024
Merged
Conversation
- Add missing treePush(id) to complement treePop() - Add basic functions to access ImGui's state storage. Limited to booleans for now with automatic ID scoping. - Fix ui.invisibleButton() requiring an explicit flag parameter even if empty
- Small delay before displaying button tooltip, better matches the rest of the UI - Consistent font choice with rest of UI
- Ensure the tab function receives a reference to the self argument - Reload only the actively selected tab when pressing Ctrl+R
- Allows taking an existing table value and making a copy with some values overridden - Primary usecase is "inline modification" of a plain table (i.e. not a prototype or class instance) - Make table.merge() and table.append() more efficient by only checking validity of the predicate once
- Add helpers to iterate a table and return the value with the greatest or least score according to the passed scoring function along with the "winning" score - Add constant-time class inheritance lookup via cached inheritance map - Fix erroneous use of table.append() instead of table.merge()
- Add type information to Event.Register - Add additional method prototypes to Ship.meta.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a batch of changes and improvements harvested from my
equip-v2branch (#5734). I'm pulling these out to make the rebase workload less insane, as they are all standalone changes with limited scope and are uncontroversial in nature.Note that many of these additions don't appear to have users (yet) - the downstream code still lives in
equip-v2awaiting merge.I don't expect much in the way of PR review here and plan to merge in <24hrs unless some sharp eye spots a bug of some sort.