Add ability to reroll random systems to System Editor#5901
Merged
sturnclaw merged 4 commits intopioneerspacesim:masterfrom Aug 25, 2024
Merged
Add ability to reroll random systems to System Editor#5901sturnclaw merged 4 commits intopioneerspacesim:masterfrom
sturnclaw merged 4 commits intopioneerspacesim:masterfrom
Conversation
- Add two new menu options: 1. re-generate system contents from current seed 2. generate random seed for current system and completely regenerate contents - These operations can only be performed on systems loaded from a procgen system due to random generation's dependence on an extant Sector::System - Can be quite helpful to get a "scaffold" system to start building a custom system from
- Wrong values used for body radius unit conversion - Don't render a close button on the primary editor viewport
- Ensure eccentricity and semi-major axis values are properly written back to individual bodies
Member
Author
|
I've tested this code to ensure it doesn't change the consistency of system layouts in bugged binary systems, so it should be compatible with old saves - not that it matters, since we're already savebumping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing on from the discussion in #5892, this PR cleans up some generation bugs in binary systems which caused the orbits of stars to change once edited (due to orbital parameters not being written back to the body), and adds a new "regenerate system from seed" functionality to quickly generate new variants of the edited system. It also addresses a unit conversion issue in body radius display when using Earth Radius as a unit.
Due to data plumbing issues, regenerating a system can only be done for a full-procedurally generated system or a "partially random" system sourced from the
local_starsdatabase of systems with randomly generated contents.2024-08-23.16-23-47.mp4