Conversation
impaktor
left a comment
There was a problem hiding this comment.
<impaktor> If the factions are hand written, I'd expect the numbering to
not be "077...", but 004 or similar
I assume changing pre-fix number changes appearance in system view?
(I'm not sure I fully understand this, but...) I don't think so. It's just the name of the file. I see no reason to change this. |
|
Files are loaded by disk iteration order, yes. There are potential knock-on effects on system generation consistency, but I haven't fully audited the code to determine whether that is the case or not. Proceed with a rename... cautiously. |
|
Actually, given that we've already merged a savebump commit, proceed with a rename with great abandon! 😄 |
|
The only think I can think of remaining is the question of a new name for Julian Science. I'm personally fine with the PR in it's current state but more than one person opposed to that name so we should look for a new one I guess. Any suggestions? Anyone? |
|
I see that I've been inconsistent with capitalization in the file/faction names. Which is preferred. |
|
All faction names are Proper Nouns, and should be capitalized as such. Every word in the name except linking verbs and articles ('a', 'an', 'the') not belonging to the faction name proper (e.x: Polity of Location, Place-by-the-Sea) should be capitalized. |
|
I bumped the Tolans expansion rate to 0.01. That gives them a dozen systems. I had a peek in the sector/system viewers and it's home world isn't inhabited. It has some three gas giants with no moons in it an nothing else. |
|
So it is ripe for a custom system? (not necesseraly in this PR) |
Yes. And I think not in this PR. |
sturnclaw
left a comment
There was a problem hiding this comment.
I think this PR is in a good state to merge, once the git history is cleaned up and fixup commits are squashed. I'll try to work on the system editor / generation issues today so custom systems can be made for each of these factions.
|
I have a branch with half done Pirate system, and Pirate Fuel Club: "Gas Guzzler", I don't quite remember if I added something more (perhaps we want to add that to the pirate faction?). My thinking is a pirate system is sort of hidden. What would an entire pirate faction be like? Sounds more like anarchy to me. But then again, there's not that much parameters for factions to tweak to make them distinct. |
3 factions removed: Blood Worlds Continuity Horde Continuity Empire 3 replacement factions: Druello Pirates Tolan kingdom Julian science
|
Nothing in that link.
☠️ |
I agree, it definitely seems weird in the abstract that a pirate organization would become an interstellar faction - however, out in the middle of independent space with little to no government larger than a planetary administration or maybe a system-wide kingdom I could see various enterprising pirates "going legit" and setting up some type of protection racket or feudal-analogue power structure with various worlds being nominally "ruled" by a nomadic interstellar navy. |
|
Amusingly, the system at Either the faction will have to be renamed (again), or I'll have to find some way to implement custom systems overriding an existing random system while also changing the name (which is used to detect if the system is overridden)... |
#5252 in one commit rebased on master.
3 factions removed:
Blood Worlds
Continuity Horde
Continuity Empire
3 replacement factions:
Druello Pirates
Tolan kingdom
Julian science
Closes #5252