Better explanation of the combat mission due date#5891
Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom Aug 23, 2024
Merged
Better explanation of the combat mission due date#5891sturnclaw merged 1 commit intopioneerspacesim:masterfrom
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Conversation
impaktor
reviewed
Aug 21, 2024
Member
impaktor
left a comment
impaktor
left a comment
There was a problem hiding this comment.
It's a bit too "on the nose", in my opinion, thus I've made some suggested re-wordings. Feel free to re-write them as you see fit. Just feels like some are really addressing the issue.
data/lang/module-combat/en.json
Outdated
| "HARVESTING_LAND_THERE": { | ||
| "description": "", | ||
| "message": "We have a salesperson in every nearby star system. This person will get in contact with you when landed." | ||
| "message": "We have a salesperson in every nearby star system. This person will get in contact with you when landed. Please note that we will not pay you if we receive the result of the mission after the due date!" |
Member
There was a problem hiding this comment.
Sounds like it's addressing the issue a bit too much.
hand-wavey suggestion:
"...when landed for payment before due date".
data/lang/module-combat/en.json
Outdated
| "MEET_ME_THERE": { | ||
| "description": "", | ||
| "message": "Meet me in the {rendezvous} system to finish the job!" | ||
| "message": "Meet me in the {rendezvous} system before the due date. Otherwise I will not pay you!" |
Member
There was a problem hiding this comment.
I'd just drop that last sentence. Sounds off, some how.
data/lang/module-combat/en.json
Outdated
| "MILITARY_LAND_THERE": { | ||
| "description": "", | ||
| "message": "Visit a station in the territory protected by the {org}!" | ||
| "message": "Visit a station in the territory protected by the {org}! This must be done before the due date! Otherwise the entire operation will fail." |
Member
There was a problem hiding this comment.
Combine the sentences to one, perhaps something like: "The operation requires targets be eliminated by date"
(assuming my guesstimation of mission flavor fits)
robothauler
force-pushed
the
combat_due_date
branch
from
97af2ff to
4fe89bc
Compare
sturnclaw
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to close #5890
The texts are shown when "How will I be paid?" is clicked.