Separating shield.models#5853
Merged
sturnclaw merged 3 commits intopioneerspacesim:masterfrom Aug 12, 2024
Merged
Conversation
(And some empty lines here and there)
Contributor
Author
|
@Web-eWorks Checked all the ships in the, their shields work properly |
Member
|
Thanks! I'll see if I can make some preliminary changes to the dev docs to include the new shield model changes. |
sturnclaw
approved these changes
Aug 12, 2024
Member
|
Thank you very much @bszlrd - your help here made the process much easier! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5840 I'm separating the shields to their own model file. Should be merged after that PR, and the hotfix release.
This sounds rather ominous: :D
@Web-eWorks All of the ships had separate shield.dae, so there was no need to touch any of the models. The #5840 builds were already expired, so I can't test, but I will do a build and check them later.
TODO: