Fix lots of missing ship labels#5842
Merged
sturnclaw merged 2 commits intopioneerspacesim:masterfrom Jun 26, 2024
Merged
Conversation
- If a model skin is applied to a model which replaces a valid text string with an empty string, the old string would continue to render because the text mesh was still valid.
- Player ship skin was created (and subsequently serialized) without a label. - Labels were not visible on ships in the new game window. - Labels also not visible in the ship market. - Labels should correctly be visible in the paint shop now. - SearchRescue target ships should now display labels on their skins as well (setting the label on the ship mutates the set skin object). - Adjusted new game window inputText widget API to support returning a changed value from the randomize function.
Member
Author
|
Picture! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #5838, and in the process fixes a number of spots where ship labels either were not appearing or may have been incorrect prior.
CC @Gliese852 - I've made minor changes to the new game window widget API and hooked a few things up to get labels to update in sync with the model spinner; just want to double check I haven't inadvertently introduced new bugs 😄
CC @bszlrd - the Coronatrix at the very least has improperly named label nodes, causing them to be picked up as tags instead. Label nodes need to be named
label_*;tag_label_*results in a tag instead. There is no need to address this immediately, but if you get five minutes it might be worth a quick fix.