Fix location recovery#5801
Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom Apr 27, 2024
Merged
Conversation
It turned out that the index of the system body in the path does not always coincide with its index in the save file, because when saving there is a separate indexing. In addition, if there are gravpoints in the system, the numbering of physical bodies and system bodies also differs, what was not taken into account. Fortunately, the physical body (planet or station) has a reference to the serializable index of the system body (index_for_system_body), and this way the reliable connection can be found.
sturnclaw
approved these changes
Mar 17, 2024
Member
sturnclaw
left a comment
sturnclaw
left a comment
There was a problem hiding this comment.
Approved pending testing. Technically, it's more efficient to calculate systemBodies only after checking for dockedToBody ~= 0, but that's not a big deal in my opinion.
Contributor
Author
|
@Web-eWorks in fact, it is also needed in the opposite case, in the implicit else, if the ship is saved in space. |
sturnclaw
approved these changes
Apr 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turned out that the index of the system body in the path does not always coincide with its index in the save file, because when saving there is a separate indexing.
In addition, if there are gravpoints in the system, the numbering of physical bodies and system bodies also differs, what was not taken into account.
(This led to errors when recovering the location.)
Fortunately, the physical body (planet or station) has a reference to the serializable index of the system body (
index_for_system_body), and this way the reliable connection can be found.