X Tutup
Skip to content

A few spelling / grammar fixes#5780

Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
SuborbitalPigeon:english
Feb 24, 2024
Merged

A few spelling / grammar fixes#5780
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
SuborbitalPigeon:english

Conversation

@SuborbitalPigeon
Copy link
Contributor

I've found a few spelling and grammar errors, I've fixed these in one commit.

I also found a few uses of Commonwealth english, things like 'behaviour'. I think it would make sense in-universe to keep these as there will be people from all sorts of brackgrounds, and some would use British forms of spelling and so on. I've made this a separate commit which can be ignored if these changes aren't desired.

@bszlrd bszlrd added the Cleanup label Feb 24, 2024
Copy link
Member

@impaktor impaktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we want to do as few updates to translated strings as possible, to not trigger re-translation in all languages.

My belief is we're generally following British English. (Also, there's different spellings of UK English in regards to -ize vs. -ise,).

With that said, I think we keep our colour, favourite, behavioural, etc.

@RacerBG
Copy link

RacerBG commented Feb 24, 2024

Ideally we want to do as few updates to translated strings as possible, to not trigger re-translation in all languages.

I'm fine with this. These grammar errors are not present in the translations so a simple save & review does the job.

@sturnclaw
Copy link
Member

sturnclaw commented Feb 24, 2024

My belief is we're generally following British English.

I don't think (as an American English speaker) that there's anything necessarily set in stone regarding use of one or the other, but the existing precedent in our language strings is for the British spelling rather than the American spelling.

That being said, thanks for the spelling fixes! It's definitely worth a bit of translation workload to address mis-spelled words, especially when we have (at least) several weeks for the translation churn to be looked at before a release.

@sturnclaw sturnclaw merged commit 7641a7f into pioneerspacesim:master Feb 24, 2024
@SuborbitalPigeon SuborbitalPigeon deleted the english branch February 25, 2024 16:04
@fluffyfreak
Copy link
Contributor

It's because it was started by TomM (UK), I'm UK, RobN (AUS), plus a few others... also given my other career it's been nice to work on a game where we could keep the UK spellings 😆

@Keeper1st
Copy link
Contributor

Heck, I have a whole crapload of such fixes if you want 'em, as well rewriting headlines as headlines (i.e. not as prose), having taxi passengers say different things depending on their occupation, and so on. Takes me ages to re-insert my fixes into the game every time I update it...

@zonkmachine
Copy link
Member

I'm happy to translate more strings.

@Keeper1st
Copy link
Contributor

Here are my current language files. http://www.keeper1st.com/pioneer/data.zip Not all have had corrections or changes, but most. Some are minor punctuation like fixing improper comma usage. Some are actual spelling issues or cleaning up awkward prose (e.g. "No more space for more cargo"). Some are more important like not assuming the player is male. Some are rewrites (e.g. taxi passengers either for more variety in what they say or in making the way they talk reflect their profession). Headlines are rewritten as headlines and not prose (e.g. instead of "The gas algae harvest in the {system} system is above average" it becomes "Gas algae harvest in {system} above average"). One is a little nod to modern air traffic control: adding "Good day" to one of the sign-offs from a station as you leave their space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

X Tutup