Don't crash when there are few background stars#5778
Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom Feb 24, 2024
Merged
Don't crash when there are few background stars#5778sturnclaw merged 1 commit intopioneerspacesim:masterfrom
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Conversation
If the user sets a small AmountOfBackgroundStars, a small diameter ball is scanned. So small that the number of tasks becomes comparable to the height of this ball, and rounding problems begin to appear. Rethought the intervals for tasks a little, now it seems to be fairly uniform for such cases. Also, if the user selects the number of stars to be 0, we simply do nothing.
sturnclaw
approved these changes
Feb 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user sets a small
AmountOfBackgroundStars, a small diameter ball is scanned. So small that the number of tasks becomes comparable to the height of this ball, and rounding problems begin to appear.Rethought the intervals for tasks a little, now it seems to be fairly uniform for such cases.
Also, if the user selects the number of stars to be 0, we simply do nothing.
Fixes #5777