Fixed broken screenshots links#5761
Conversation
Fixed broken screenshots links in metainfo.xml file
sturnclaw
left a comment
sturnclaw
left a comment
There was a problem hiding this comment.
These images should not be sourced from a link to the file in the source tree, as they're unlikely to embed properly at all (Github serves an HTML document at that link rather than a PNG file).
These images are available as https://pioneerspacesim.net/carousel/ss1.png etc. and should be linked to using links of that form instead.
|
Sorry, might have been me that sent @VasanthBalguri down the wrong track. |
updated as per comments
|
Hi, I made changes according to comments.
|
|
That's not intentional, the metainfo file just hasn't been updated since then. |
|
Oh okay, then I will update, is it okay?
…On Tue, 13 Feb, 2024, 11:41 am Webster Sheets, ***@***.***> wrote:
That's not intentional, the metainfo file just hasn't been updated since
then.
—
Reply to this email directly, view it on GitHub
<#5761 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE6DBOPIUZLBD7D2WY24QYDYTL7XPAVCNFSM6AAAAABDDT7LP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBQGQ4DINBYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes please |
|
It is done @impaktor and @Web-eWorks, pleas check. |
3 participants
Fixed broken screenshots links in metainfo.xml file
Fixes #5747 issue