Fix orbital / surface scan missions being unable to be completed#5724
Merged
sturnclaw merged 2 commits intopioneerspacesim:masterfrom Jan 27, 2024
Merged
Fix orbital / surface scan missions being unable to be completed#5724sturnclaw merged 2 commits intopioneerspacesim:masterfrom
sturnclaw merged 2 commits intopioneerspacesim:masterfrom
Conversation
- This caused Scout missions to be unable to be completed, as well as causing issues with the hyperjump planner. - The constraint on the new Event API is that a module may only register 1 handler per event per file, for the purpose of automatically overwriting the event handler when the module code is hot-reloaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an unintended consequence of #5671, two modules were inadvertently overwriting their previously-registered event handlers by dint of not conforming to the existing usage pattern of one handler per event per file. This pattern was made a requirement to support hot-reloading of registered event handlers, but I didn't realize we had some existing code which broke that pattern before I merged the PR.
This PR fixes an issue reported at least once on Discord where scan missions were unable to be completed after loading a saved game with an in-progress scan. I don't believe it's yet been reported over here.