Fix assert on startup when calling back on an empty string#5717
Merged
sturnclaw merged 2 commits intopioneerspacesim:masterfrom Jan 19, 2024
Merged
Fix assert on startup when calling back on an empty string#5717sturnclaw merged 2 commits intopioneerspacesim:masterfrom
sturnclaw merged 2 commits intopioneerspacesim:masterfrom
Conversation
f5f76d9 to
7b2770f
Compare
Contributor
|
The question is, why |
Member
|
The module name is empty because This technically exposes a flaw in the new Event system where C++ can only register one Lua callback handler for each event type without overwriting the previously-set handler. That's not a problem in practice (as generally speaking a C++ function shouldn't be listening for a Lua event but rather use a sigc::signal instead), but something I'll have to keep in mind for the future. |
sturnclaw
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5716