Fix installed directory structure on Windows#5686
Fix installed directory structure on Windows#5686sturnclaw merged 3 commits intopioneerspacesim:masterfrom
Conversation
- Don't use GNUInstallDirs on a non-unix system - Default to installing binaries + data together in the same folder
This may resolve some issues where MSVC is generating UTF-16 or other non UTF-8 bitpatterns to encode these characters
|
What I see if that you have a install() in the top CMake script, why isn't it in the cmake/InstallPioneer.cmake, below the spot where CMAKE_INSTALL_BINDIR is overriden? |
|
@Web-eWorks |
|
That should also be fixed now. |
|
Confirmed, it works properly now. |
Replying after the fact, but essentially the InstallPioneer script is intended to setup installation directories at the start of the CMakeFile, but the |
3 participants
During the last major change to CMake I accidentally broke the install structure on Windows. This PR resolves that and should make the installation behavior on Windows systems more robust and easier to understand.
I've also included a potential fix for MSVC doing strange things with unicode character escape sequences in C string literals by explicitly specifying that we want the UTF-8 encoding of the unicode character.
CC @nozmajner @pcercuei to give this a test on Windows if able.