Fix for commodity market in stock and demand reset#5633
Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom Oct 6, 2023
Merged
Fix for commodity market in stock and demand reset#5633sturnclaw merged 1 commit intopioneerspacesim:masterfrom
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Conversation
Fixes commodity market in stock and demand reseting on save load
Max5377
force-pushed
the
CommodityMarketReset-fix
branch
from
2c4c85f to
33b406c
Compare
Member
|
I may not have a chance to properly test this for a few days, but the code looks correct. If someone is able to test and report back here, that'd be excellent - otherwise I'll merge once I've gotten a chance to ensure the solution functions correctly. |
sturnclaw
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5582
This happened, because
transientMarketinSpaceStation.luawas never linked tostationMarketinEconomy.luaafter loading the save. AddingcreateCommodityStock(station)in loopfor station,list in pairs(loaded_data.shipsOnSale) doin theonGameStartevent will make sure to do that for every station player has visited in the system.Update
Changed to a more clean-looking solution.