X Tutup
Skip to content

Mouseover messages for the ECM and the Advanced ECM systems#5590

Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
zonkmachine:ecm
Jun 14, 2023
Merged

Mouseover messages for the ECM and the Advanced ECM systems#5590
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
zonkmachine:ecm

Conversation

@zonkmachine
Copy link
Member

Implement hover over messages for the ECM and ECM Advanced.

ecm3

  • The message is just Electronic countermeassure and Advanced electronic countermeassure. This harmonizes with the messages for the missiles above which just state the missile types.
  • The hover over message for the missiles capitalize the first letters on all words and this PR doesn't. Which one is preferred?

ecm1

Fixes #5215

@zonkmachine zonkmachine marked this pull request as draft June 12, 2023 15:47
@zonkmachine
Copy link
Member Author

Converted to draft. I still have some questions on the wording (see post above).

@impaktor
Copy link
Member

I suspect capitalization is more in line what we're doing / intend to do. But then @Web-eWorks is the only native speaker here.

@zonkmachine
Copy link
Member Author

I suspect capitalization is more in line what we're doing / intend to do. But then @Web-eWorks is the only native speaker here.

OK, fixed that.

@zonkmachine zonkmachine marked this pull request as ready for review June 12, 2023 20:29
@zonkmachine zonkmachine force-pushed the ecm branch 2 times, most recently from b5cc061 to 4db769c Compare June 12, 2023 20:43
@zonkmachine
Copy link
Member Author

I wonder if the message should be the same for both ECM types. 'Activating Advanced Electronic Countermeasures' sound a bit too much.

@zonkmachine zonkmachine changed the title Hower on messages for the ECM and the Advanced ECM systems Mouseover messages for the ECM and the Advanced ECM systems Jun 13, 2023
@sturnclaw
Copy link
Member

Sorry about the response delay. Ideally, we'd differentiate the two types of ECM equipment separately via an icon or some other visual indicator, so I'm generally in favor of using the same "Activate Electronic Countermeasures" tooltip for both. I don't think it makes sense to have basic and advanced ECM generators installed simultaneously and not activate both when attempting to defeat a missile, so having separate activation buttons isn't something we'd be aiming for.

@zonkmachine
Copy link
Member Author

so I'm generally in favor of using the same "Activate Electronic Countermeasures" tooltip for both.

Yes, this sounds better. Fixed!

I think I'm happy with the PR now.

@bszlrd
Copy link
Contributor

bszlrd commented Jun 14, 2023

There should be a different icon for both types of ECM (single and double thunder, and as far as I can see, the icon set is set up that way)
image

@zonkmachine
Copy link
Member Author

Yes, the icons are showing correctly.

@sturnclaw sturnclaw merged commit 81b723c into pioneerspacesim:master Jun 14, 2023
@zonkmachine zonkmachine deleted the ecm branch June 15, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ECM popup text is not informative

4 participants

X Tutup