Fix autopilot crash, when no mass in frame of reference#5551
Fix autopilot crash, when no mass in frame of reference#5551sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Conversation
|
@azieba I guess any multisystem contains a root frame without a physical body ( P.S. Sorry, hit the button by accident. |
|
I have a 20230203-level savegame that when I hyperspace to Sirius (1, 0, -1), a multi-star system:
Environment: |
So I guess we have an independent verification. Thank you! |
|
You're welcome 😄 I am still getting occasional crashes to desktop with this PR applied, typically when autopilot is engaged inbound to a starport - i.e. not immediately upon arriving at the system as previously described. This can occur in single-star systems also, e.g. my last occurrence was returning to Los Angeles, Sol (journey from arrival point to starport about 75% complete). I'm not sure but the CTD could be occurring when the frame of reference changes..? I'd like to supply a backtrace / call stack, but I cannot currently compile a debug version (issue #5545). |
|
|
Apologies on waiting so long to merge this PR - it slipped my mind that this was already in-progress and waiting on review/merge. |
Fixes #5535. The problem is for systems with no star in the main frame of reference. Are they even valid?