X Tutup
Skip to content

Fix autopilot crash, when no mass in frame of reference#5551

Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
azieba:no_planet_neer
Mar 3, 2023
Merged

Fix autopilot crash, when no mass in frame of reference#5551
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
azieba:no_planet_neer

Conversation

@azieba
Copy link
Contributor

@azieba azieba commented Feb 17, 2023

Fixes #5535. The problem is for systems with no star in the main frame of reference. Are they even valid?

@impaktor impaktor changed the title Fixes #5535 Fix autopilot crash, when no mass in frame of reference Feb 17, 2023
@Gliese852
Copy link
Contributor

Gliese852 commented Feb 18, 2023

@azieba I guess any multisystem contains a root frame without a physical body ( BodyType::TYPE_GRAVPOINT).

P.S. Sorry, hit the button by accident.

@Gliese852 Gliese852 closed this Feb 18, 2023
@Gliese852 Gliese852 reopened this Feb 18, 2023
@craigo-
Copy link
Contributor

craigo- commented Feb 19, 2023

I have a 20230203-level savegame that when I hyperspace to Sirius (1, 0, -1), a multi-star system:

Environment:
Windows 10 Enterprise 22H2
Compilations performed using Visual Studio 2019 16.11.24 using CMake instructions and x64-Release configuration

@azieba
Copy link
Contributor Author

azieba commented Feb 19, 2023

So I guess we have an independent verification. Thank you!

@craigo-
Copy link
Contributor

craigo- commented Feb 19, 2023

You're welcome 😄

I am still getting occasional crashes to desktop with this PR applied, typically when autopilot is engaged inbound to a starport - i.e. not immediately upon arriving at the system as previously described. This can occur in single-star systems also, e.g. my last occurrence was returning to Los Angeles, Sol (journey from arrival point to starport about 75% complete).

I'm not sure but the CTD could be occurring when the frame of reference changes..?

I'd like to supply a backtrace / call stack, but I cannot currently compile a debug version (issue #5545).

@azieba
Copy link
Contributor Author

azieba commented Feb 19, 2023

I'd like to supply a backtrace / call stack, but I cannot currently compile a debug version (issue #5545).

Debug versions have asserts active so they crash much more often even though release works fine. If such assert is in a way I comment it out to proceed.
EDIT: This is not an assert issue.
Save file would be actually more useful if you have one.
EDIT2: I could not reproduce with the journey to Los Angeles.

@sturnclaw
Copy link
Member

Apologies on waiting so long to merge this PR - it slipped my mind that this was already in-progress and waiting on review/merge.

@sturnclaw sturnclaw merged commit c58d3bb into pioneerspacesim:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pioneer crashes when unpausing

4 participants

X Tutup