Fix station pads being assigned wrong bay indicies#5488
Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom Jan 26, 2023
Merged
Fix station pads being assigned wrong bay indicies#5488sturnclaw merged 1 commit intopioneerspacesim:masterfrom
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Conversation
- Bay index was dependent on order of tags in the model file, which can vary depending on exporter etc. - Load bay index from tag name instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bay index assigned to pads was dependent on order of tags in the model file, which can vary depending on the exporter used to generate the model. This caused a mismatch between what was displayed on the UI and which tag was used as the 'landing location'. Instead, the bay index is now determined (correctly) from the
_bNNportion of the tag name.Fixes #5408.