Miscellaneous fixes and improvements#5455
Merged
sturnclaw merged 4 commits intopioneerspacesim:masterfrom Dec 25, 2022
Merged
Conversation
- Add type information for body:exists(), :isa(), :setprop(), :hasprop() methods
- Jumps to the currently selected sector map target
- Add StarSystem.numberOfBodies attribute - Add StarSystem.numberOfStations attribute Avoids having to generate an entire table of body paths just to check whether there are in fact bodies inside the system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expect a short shelf-life before merge.
This PR adds more type information to Lua autocomplete files, fixes one unreported UI error when pumping fuel in hyperspace, and adds a debug utility to hyperjump to the star selected in the Sector Map. As usual, this debug button is present in the Ship Spawner for lack of a better place to put it right now, and requires the player to be undocked. It ignores maximum range and fuel costs, and can happily hyperjump you directly to Sag A* if you scroll long enough to get there...
This also adds two new attributes to LuaStarSystem to avoid having to generate a potentially expensive Lua table just to query the number of bodies or spacestations in a system.