Fix MusicPlayer crashing when music ends on sector view while in hyperspace#5425
Fix MusicPlayer crashing when music ends on sector view while in hyperspace#5425sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Conversation
|
This seems to have resolved the crash involving the music player change in System View when hyperspacing to an uninhabited system. When hyperspacing to a inhabited system, the game still crashes, music or not... |
If it still crashes on current master, then please report that @Damjan94, now that we know the music crash bug is fixed. |
I haven't actually got to play the game yet, but it shouldn't crash anymore... |
|
The issue was tracked in #5424, and this PR addressed one half of the mentioned issue. The other crash condition (an actual segfault) was addressed separately in another PR. No further issue reporting is required as long as no new crash bugs have been found. |
4 participants
Reported on IRC. Just adding one more condition to check on track end.
Please excuse the commit description.