FuelClub: Refuel internal fuel tank only once a day#5311
FuelClub: Refuel internal fuel tank only once a day#5311sturnclaw merged 3 commits intopioneerspacesim:masterfrom
Conversation
|
I think there should also be edits to the language file, so when you ask for the rules/contract there's a "we'll refuel you once per day", or similar, somewhere, where it's fitting. |
|
If anyone has play tested this / tried to get it to break, please let us know. I assume we're aiming for merging stuff for a February 3rd release again... |
|
played a little bit, found this:
=> no refill, the first call of the foundation has blocked the function yet, although no fuel has been transferred. I assume the same behave when you come back from fuel scooping and like to sell hydrogen to the foundation (fuel scooping always fails in this branch from code heritage). It will fill the missing 0.xxx tons when you first enter the fuel foundation as you can only transfer integer amounts to the tank. I thought further to block automatic refuel function if a tank has less than 3% / 3t or so capacity left, but then you maybe want to force refueling when your tank is small, so you need a button for this... ...but if you add a button there anyway, you can directly call it "free tank refill for today" and skip the automatic background function. |
|
fine work, nothing found (maybe a one-time cheat when a game from certain earlier versions is loaded, but once you save in this version, it's safe, i'd say there is no need for more code to prevent this single event) What about #5282? There is still some possibility for arbitrage, but the quantities are very limited now. The clubs still don't accept taking back more waste than military fuel sold, i tested this also. |
Members get refueled every time and can sell the internal fuel over and over again.
This PR prevents that and limits the refilling to once a day after takeoff.