make fuel scooping less of a suicide#5281
Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom Oct 1, 2021
Merged
Conversation
speed and density factored in to how much is scooped hasnt changed, only the threshold where it starts scooping scooping is still non-trivial
Contributor
|
Feels good to me, based on the save I got from discord. I was able to scoop a full hold of H2 with a Mola Mola, and still had to climb out to orbit. |
Contributor
|
I've took the liberty to edit your description with the Fixes #5237 line for auto-closing that issue upon merge |
Contributor
Author
|
note to reviewers: the ease of fuel scooping depends heavily on the planet youre scooping. without the patch I had to nose-down pretty hard and pass below 40km altitude, praying that aerodynamics wouldnt push me into a death spin and that id'd be able to pull up again, while having maybe a 50/50 chance of scooping anything. this patch changes scooping from a russian roulette to "keep your hands on the wheel at all times" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
speed and density factored in to how much is scooped hasnt changed, only the threshold where it starts scooping
scooping is still non-trivial
Fixes #5237