X Tutup
Skip to content

fix crash from selling when amount=0#5262

Merged
impaktor merged 1 commit intopioneerspacesim:masterfrom
jimishol:fix_SoldOut
Sep 14, 2021
Merged

fix crash from selling when amount=0#5262
impaktor merged 1 commit intopioneerspacesim:masterfrom
jimishol:fix_SoldOut

Conversation

@jimishol
Copy link
Contributor

@jimishol jimishol commented Sep 13, 2021

Fixes #5251 by closing the form, so player can not sell when amount=0.

@impaktor
Copy link
Member

I could edit your post to be correct, but better to teach: Please use word "fixes #5251" in the body of your post (above), and change title to something like "fix crash from something something" (but better than I suggested here), we don't put URLs in the title.

@jimishol jimishol changed the title fixes https://github.com/pioneerspacesim/pioneer/issues/5251 fix crash from selling when amount=0 Sep 14, 2021
@impaktor impaktor merged commit 417eb97 into pioneerspacesim:master Sep 14, 2021
@jimishol jimishol deleted the fix_SoldOut branch September 14, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Soldout module allows to sell more than a trader needs causing fatal error

2 participants

X Tutup