Fixing the normals issue of the DSMiner#5229
Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom Jul 18, 2021
Merged
Fixing the normals issue of the DSMiner#5229sturnclaw merged 1 commit intopioneerspacesim:masterfrom
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Conversation
Contributor
|
maybe it should have been that concave? (or convex) |
sturnclaw
approved these changes
Jul 18, 2021
Member
sturnclaw
left a comment
sturnclaw
left a comment
There was a problem hiding this comment.
This gets my thumbs-up - the old normals looked very ugly, and if it needed to be concave it would have been much better to simply model it in or bake it to the normal map instead of messing with vertex normals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was some kind of normals issue on the high lod of the DSMiner. Not sure how it got there, or when. It was an eyesore, so I've figured I fix it since we are having a release soon.
Before:
After: