X Tutup
Skip to content

Fix low-hanging bugs in prep for mid-year release#5224

Merged
sturnclaw merged 6 commits intopioneerspacesim:masterfrom
sturnclaw:microfixes
Jul 16, 2021
Merged

Fix low-hanging bugs in prep for mid-year release#5224
sturnclaw merged 6 commits intopioneerspacesim:masterfrom
sturnclaw:microfixes

Conversation

@sturnclaw
Copy link
Member

@sturnclaw sturnclaw commented Jul 6, 2021

This is a maintenance PR to clean up a few outstanding bugs and prep a release before we merge the renderer rewrite and other PRs that make major changes and take the master branch unstable.

image

sturnclaw added 3 commits July 5, 2021 19:15
- Esc key closes the options window in game
- Show an error message when a UI tab encounters an error
- Fix flightlog buttons being offscreen
- Fix array table sort indicator being reversed
@sturnclaw
Copy link
Member Author

I will not be fixing the clang-format error, as it is caused by a bug introduced into clang-format itself.

@sturnclaw sturnclaw force-pushed the microfixes branch 2 times, most recently from edd9954 to 9c109fb Compare July 6, 2021 00:14
@impaktor
Copy link
Member

impaktor commented Jul 6, 2021

Just repeating what I said on IRC, about the error message:

  • it would be good if it gave the path to the output log
  • is providing save file more/less important than description of how to reproduce, or both? (It doesn't mention the latter)

@sturnclaw sturnclaw merged commit 1c038c6 into pioneerspacesim:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

X Tutup