X Tutup
Skip to content

Improve/fix system map#5123

Merged
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Gliese852:orbits-and-cargo
Feb 1, 2021
Merged

Improve/fix system map#5123
sturnclaw merged 1 commit intopioneerspacesim:masterfrom
Gliese852:orbits-and-cargo

Conversation

@Gliese852
Copy link
Contributor

@Gliese852 Gliese852 commented Jan 19, 2021

  • add a "static" orbit for bodies that are not moving anywhere
  • now bodies in a rotating frame, and also in the space port frame have such "static" orbits
  • add display of the orbits of objects moving strictly to the star or from the star
  • also fix compile warning for possibly uninitiated variable in LuaSystemView.cpp
  • also fix an issue where smooth animation sometimes have a hard time catching up with a newly selected object:
animation.mp4

Fixes #5062

@Gliese852 Gliese852 force-pushed the orbits-and-cargo branch 5 times, most recently from 4d3e616 to 9c1f02a Compare January 20, 2021 15:03
@Bodasey
Copy link

Bodasey commented Jan 21, 2021

I have tested this version for an hour - i'd say FIX CONFIRMED

- add a "static" orbit for bodies that are not moving anywhere
- now bodies in a rotating frame and also in the spaceport frame have
  such "static" orbits
- add display of the orbits of objects moving strictly to the star or
  from the star
- fix compile warning for possibly uninitiated variable in
  LuaSystemView.cpp
- fix an issue where smooth animation sometimes have a hard time
  catching up with a newly selected object

Fixes pioneerspacesim#5062
@impaktor
Copy link
Member

I assume this can be merged. If not, speak up. If someone/@Gliese852 needs it in master now/soon: speak up.

@sturnclaw sturnclaw merged commit 5004b09 into pioneerspacesim:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System viev: Ship vanishes when the reference system is an orbital starport

4 participants

X Tutup